Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13222 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner December 9, 2025 07:14
@azure-sdk azure-sdk requested review from Copilot and hallipr December 9, 2025 07:14
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools PR #13222, specifically enhancing the PowerShell logging script to provide better fallback behavior in non-CI environments. The change adds an else clause to LogGroupStart() that outputs a simple prefix marker when neither Azure DevOps nor GitHub Actions logging is available, making log grouping visible during local development.

Key Changes:

  • Added fallback logging to LogGroupStart() for non-CI environments
Comments suppressed due to low confidence (1)

eng/common/scripts/logging.ps1:109

  • The LogGroupEnd() function is missing a fallback else clause to match the newly added fallback in LogGroupStart(). For consistency and to ensure proper pairing of group markers in non-CI environments, consider adding:
else {
  Write-Host ""
}

This ensures that group start/end operations are balanced across all environments, improving maintainability and debugging experience.

function LogGroupEnd() {
  if (Test-SupportsDevOpsLogging) {
    Write-Host "##[endgroup]"
  }
  elseif (Test-SupportsGitHubLogging) {
    Write-Host "::endgroup::"
  }
}

@hallipr hallipr merged commit c6b1bc5 into main Dec 9, 2025
23 of 27 checks passed
@hallipr hallipr deleted the sync-eng/common-users/pahallis/local-group-start-13222 branch December 9, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants