Remove fixedint#43659
Merged
jeremydvoss merged 5 commits intoAzure:mainfrom Nov 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the fixedint dependency from the azure-monitor-opentelemetry-exporter package by replacing it with manual 32-bit integer overflow handling. The key changes include:
- Removed
fixedintfrom runtime dependencies and moved it to dev requirements for testing purposes - Replaced
Int32type fromfixedintwith manual overflow logic in the DJB2 hash function - Renamed constants
_INTEGER_MAXand_INTEGER_MINto_INT32_MAXand_INT32_MINwith explicit value definitions - Added comprehensive test coverage for the
_get_DJB2_sample_scorefunction
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed fixedint from runtime install_requires dependencies |
| dev_requirements.txt | Added fixedint as a dev-only dependency for testing |
| _utils.py | Implemented manual 32-bit overflow handling to replace Int32 usage and renamed constants |
| _constants.py | Replaced fixedint.Int32 constants with explicit 32-bit integer boundary values |
| test_trace_utils.py | Added new comprehensive test suite for _get_DJB2_sample_score function |
| CHANGELOG.md | Updated changelog to document the removal of fixedint dependency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/opentelemetry/exporter/export/trace/_utils.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hectorhdzg
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove fixedint to reduce dependency footprint. This will help attach rate by limiting dependency overlap surface.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines