Sync eng/common directory with azure-sdk-tools for PR 12529 #43538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools PR #12529, focusing on improving stress test package discovery and deployment robustness. The changes add safety checks and clearer logging when no stress test packages are found.
Key Changes:
- Added early exit with warning when no stress test packages are discovered
- Added conditional logging to avoid errors when no chart files exist
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 | Adds validation to exit gracefully with a warning when no stress test packages are found |
| eng/common/scripts/stress-testing/find-all-stress-packages.ps1 | Wraps chart file logging in a conditional check to prevent errors when no files exist |
benbp
approved these changes
Dec 4, 2025
benbp
deleted the
sync-eng/common-benbp/stress-throw-on-no-match-12529
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12529 See eng/common workflow