Update Batch SDK to use new API version 2018-12-01 by xingwu1 · Pull Request #4072 · Azure/azure-sdk-for-python

xingwu1 · 2018-12-14T20:11:08Z

No description provided.

adxsdk6 · 2018-12-14T20:11:10Z

Can one of the admins verify this patch?

adxsdk6 · 2018-12-14T20:11:11Z

Can one of the admins verify this patch?

xingwu1 · 2018-12-14T20:11:28Z

@matthchr @bgklein Please review the change.

matthchr

Had one minor comment on the changelog

matthchr · 2018-12-14T20:12:05Z

azure-batch/HISTORY.rst

Use [ around breaking (match with below)

I remove the [] to match the old history.

bgklein · 2018-12-14T20:25:00Z

azure-batch/azure/batch/operations/task_operations.py

Nit: I beleive this description is overwritten by patch.py build_new_add_collection method, so if we want this displayed in documentation must copy there as well

bgklein · 2018-12-14T20:31:46Z

Did we want to ping/have @lmazuel run his magical script to collapse models to one file. Should make doc's a little cleaner and solve the import issue Jake ran into.

azure-batch/azure/batch/batch_service_client.py

lmazuel · 2018-12-15T00:35:42Z

@bgklein I think you should indeed :)

lmazuel · 2018-12-15T00:36:20Z

azure-batch/azure/__init__.py

Not ok, keep the pkgutil file

@xingwu1 You need to remove line 1, right now your file has two lines, one with pkgresources, one with pkgutil

xingwu1 · 2018-12-17T06:40:34Z

@lmazuel Do you have the script? How can I run it?

lmazuel · 2018-12-17T20:24:14Z

@xingwu1 Script is here:
https://gist.github.com/lmazuel/dad0ac92c733b27f6d81ea57a47625ce#file-patch_models_v2-py

You need to pip install -e azure-batch, and call the script "python patch_models_v2.py azure.batch". This should patch locally your files, to something that looks like this:
https://github.com/Azure/azure-sdk-for-python/tree/master/azure-cognitiveservices-vision-contentmoderator/azure/cognitiveservices/vision/contentmoderator/models

@iscai-msft is currently porting the logic of this script into Autorest itself, for Autorest.Python v4. But the output will be exactly the same. This script is used already by the CLI to shrink the Windows MSI installer (for a few months), so it's safe to assume it's stable.

xingwu1 · 2018-12-17T23:20:05Z

@lmazuel Let me know if there has anything to change.

codecov-io · 2018-12-18T08:14:20Z

Codecov Report

Merging #4072 into master will decrease coverage by 0.07%.
The diff coverage is 99.8%.

@@            Coverage Diff             @@
##           master    #4072      +/-   ##
==========================================
- Coverage   54.23%   54.16%   -0.08%     
==========================================
  Files       10241     9830     -411     
  Lines      207887   207475     -412     
==========================================
- Hits       112751   112373     -378     
+ Misses      95136    95102      -34

Impacted Files	Coverage Δ
azure-batch/azure/batch/models/_models.py	`65.62% <ø> (ø)`
azure-batch/azure/batch/custom/patch.py	`80.18% <ø> (ø)`	⬆️
azure-batch/azure/batch/models/_models_py3.py	`65.62% <ø> (ø)`
.../azure/batch/models/_batch_service_client_enums.py	`100% <100%> (ø)`
azure-batch/azure/batch/models/_paged_models.py	`100% <100%> (ø)`
azure-batch/azure/batch/models/__init__.py	`100% <100%> (ø)`	⬆️
azure-batch/azure/batch/batch_service_client.py	`95.55% <83.33%> (+0.2%)`	⬆️
...re-batch/azure/batch/operations/task_operations.py	`73.82% <0%> (ø)`	⬆️
...re-batch/azure/batch/operations/file_operations.py	`74.68% <0%> (ø)`	⬆️
.../azure/batch/operations/compute_node_operations.py	`71.91% <0%> (ø)`	⬆️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26611f2...20bd704. Read the comment docs.

lmazuel · 2018-12-18T17:28:14Z

@xingwu1 @matthchr @bgklein LGTM, I feel ready to merge and release once I have your go :)

bgklein · 2018-12-18T18:01:18Z

Changes look good to me. @matthchr is OOF until the new year. We should be good to merge and release

lmazuel · 2018-12-19T01:06:46Z

@bgklein "should" ? :). May I humbly ask you a more assertive sentence about this, since once it's released, it cannot be undone :)

xingwu1 · 2018-12-19T02:31:46Z

@lmazuel please merge it.

Update data plane SDK with new API 2018-12-01

5141483

xingwu1 requested review from annatisch and matthchr as code owners December 14, 2018 20:11

matthchr approved these changes Dec 14, 2018

View reviewed changes

bgklein reviewed Dec 14, 2018

View reviewed changes

xingwu1 force-pushed the master branch 4 times, most recently from 68e7d10 to 3592e7b Compare December 14, 2018 22:38

bgklein approved these changes Dec 14, 2018

View reviewed changes

xingwu1 force-pushed the master branch 3 times, most recently from 8da7efd to bd0a358 Compare December 14, 2018 23:01

lmazuel reviewed Dec 15, 2018

View reviewed changes

azure-batch/azure/batch/batch_service_client.py Outdated Show resolved Hide resolved

Azure deleted a comment from codecov-io Dec 15, 2018

lmazuel reviewed Dec 15, 2018

View reviewed changes

Update test cases for new API.

5194b52

xingwu1 force-pushed the master branch from bd0a358 to 5194b52 Compare December 17, 2018 06:39

This was referenced Dec 18, 2018

[AutoPR batch/data-plane] Add Batch dataplane API version 2018-12-01.8.0 #4010

Closed

[AutoPR batch/data-plane/batch/resource-manager] typo: Microsoft.Batch #3904

Closed

[AutoPR] batch/data-plane #4031

Closed

Merged model classes into single file.

20bd704

xingwu1 force-pushed the master branch from da05bbb to 20bd704 Compare December 18, 2018 07:58

lmazuel merged commit 92c969f into Azure:master Dec 20, 2018

Comments

Conversation

xingwu1 commented Dec 14, 2018

Uh oh!

adxsdk6 commented Dec 14, 2018

Uh oh!

adxsdk6 commented Dec 14, 2018

Uh oh!

xingwu1 commented Dec 14, 2018

Uh oh!

matthchr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bgklein commented Dec 14, 2018

Uh oh!

Uh oh!

lmazuel commented Dec 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xingwu1 commented Dec 17, 2018

Uh oh!

lmazuel commented Dec 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xingwu1 commented Dec 17, 2018

Uh oh!

codecov-io commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lmazuel commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bgklein commented Dec 18, 2018

Uh oh!

lmazuel commented Dec 19, 2018

Uh oh!

xingwu1 commented Dec 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lmazuel commented Dec 17, 2018 •

edited

Loading

codecov-io commented Dec 18, 2018 •

edited

Loading

lmazuel commented Dec 18, 2018 •

edited

Loading