Number Insight GA #38793
Merged
Number Insight GA #38793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoqing2023
requested review from
danielav7,
miguhern and
whisper6284
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
guoqing2023
force-pushed
the
guoqing/number-insight-ga
branch
2 times, most recently
from
0c3816d to
fd75edb
Compare
guoqing2023
force-pushed
the
guoqing/number-insight-ga
branch
from
fd75edb to
9384a78
Compare
guoqing2023
changed the title
guoqing2023
force-pushed
the
guoqing/number-insight-ga
branch
from
57be2ca to
2c66a51
Compare
This was referenced Jan 5, 2025
3 tasks
…g2023/azure-sdk-for-python into guoqing/number-insight-ga
…g2023/azure-sdk-for-python into guoqing/number-insight-ga
guoqing2023
force-pushed
the
guoqing/number-insight-ga
branch
from
58b6b4f to
ddd8353
Compare
guoqing2023
force-pushed
the
guoqing/number-insight-ga
branch
from
26e61a5 to
fe64431
Compare
…; Mobile Country Code -> ISO 2 Mobile Country Code
whisper6284
approved these changes
Jan 30, 2025
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* Add number lookup GA * Add GA release of Number Insight to changelog * add number insight models to init file to make them public * add PhoneNumberSearchResultError to init file to make them public * error code and error from PhoneNumberSearchResult to match previous stable version * disable pylint docstring-keyword-should-match-keyword-only * fixed async search operatorInformation * Change code comment, Mobile Network Code -> ISO 2 Mobile Network Code; Mobile Country Code -> ISO 2 Mobile Country Code * update docs * regenerate comments * fix doc comment policy issue * options becomes a kwarg * fix pylint and docs * update change logs for options as kwarg
cRui861
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Add number lookup GA * Add GA release of Number Insight to changelog * add number insight models to init file to make them public * add PhoneNumberSearchResultError to init file to make them public * error code and error from PhoneNumberSearchResult to match previous stable version * disable pylint docstring-keyword-should-match-keyword-only * fixed async search operatorInformation * Change code comment, Mobile Network Code -> ISO 2 Mobile Network Code; Mobile Country Code -> ISO 2 Mobile Country Code * update docs * regenerate comments * fix doc comment policy issue * options becomes a kwarg * fix pylint and docs * update change logs for options as kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update azure-communication-phonenumbers SDK to transit from our previous preview version to a fully supported GA version.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Packages impacted by this PR
@azure/communication-phone-numbers
Issues associated with this PR: https://skype.visualstudio.com/SPOOL/_workitems/edit/3994015/?view=edit
Provide a list of related PRs (if any)
API Specs: Azure/azure-rest-api-specs#31978
.net: Azure/azure-sdk-for-net#47195
Java: Azure/azure-sdk-for-java#43290
Python: #38793
JavaScript: Azure/azure-sdk-for-js#32095
APIView:
API Specs: https://apiview.dev/Assemblies/Review/ba16371e7b7e46b79b9be65fa0119ccd?revisionId=484ad4a29e054ee1be1df31c6c45e2ba&diffOnly=False&doc=False&diffRevisionId=ba31920ba63c477597d96aded7f0e320
.net: https://spa.apiview.dev/review/e465f73b881e41a5875a9d614a96d3ad?activeApiRevisionId=ccea565c3a4542deacc389de5ca77f2d&diffApiRevisionId=26571e2b0fda4ccd88cf379b9cb06f61
Java: https://apiview.dev/Assemblies/Review/ef288c648931473f8ac61a2248b90b1a?revisionId=d2a2455731bd45b48e472cb0609352fb&diffOnly=False&doc=False&diffRevisionId=ce79f52fc3b64f2ab3e4329e49c5e3f2
Python: API changes are not detected in this pull request.
JavaScript: https://spa.apiview.dev/review/ec5503f48f0b42cdbbb2e6bd4ec0aa87?activeApiRevisionId=88cf3f64633b493eb88ef9db82ab425b&diffApiRevisionId=553e954e8cf34d79a9f4e67c6b649416