Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-ai-projects: configure otel logging in telemetry.enable() helper #38434

Merged

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Nov 8, 2024

Fixes #38413

  1. OTel gen-ai semconv recommend using otel events (aka logs) to record prompts/completions which is what OpenAI instrumentation does. So we need to enable events (aka logs) too
  2. We should not override global tracer or logger if it was configured before, but we can modify it - fixing this
  3. Some cosmetic improvements after testing with newly released https://pypi.org/project/opentelemetry-instrumentation-openai-v2

@lmolkova lmolkova changed the title azure-ai-projects: configure otel logging in telemtery.enable() helper azure-ai-projects: configure otel logging in telemetry.enable() helper Nov 8, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-projects

@lmolkova lmolkova merged commit b31889f into Azure:feature/azure-ai-projects Nov 11, 2024
11 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants