Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing in samples #38354

Merged
merged 23 commits into from
Nov 8, 2024
Merged

Fix typing in samples #38354

merged 23 commits into from
Nov 8, 2024

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Nov 6, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the AI label Nov 6, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-projects

@nick863 nick863 merged commit c6edff5 into feature/azure-ai-projects Nov 8, 2024
10 of 20 checks passed
@nick863 nick863 deleted the nirovins/fix_mypy_III branch November 8, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhakulin jhakulin jhakulin approved these changes

@dargilco dargilco dargilco approved these changes

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@achauhan-scc achauhan-scc Awaiting requested review from achauhan-scc achauhan-scc is a code owner

@kingernupur kingernupur Awaiting requested review from kingernupur kingernupur is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

Assignees
No one assigned
Labels
AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nick863 @azure-sdk @jhakulin @dargilco