Skip to content

Evaluation: Fix file being used by another process error during target function execution #38021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ninghu merged 3 commits into from
Oct 22, 2024
Merged

Evaluation: Fix file being used by another process error during target function execution #38021

ninghu merged 3 commits into from
Oct 22, 2024

Conversation

@ninghu
Copy link
Contributor

@ninghu ninghu commented Oct 21, 2024 •
edited
Loading

Description

Here is a test run which proves the tracing and remote tracking still working after disabling the target snapshot:
Evaluation - Azure AI Studio

Also, to minimalize the risk, exposed a flag for user to turn it back through kwargs.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu requested a review from a team as a code owner October 21, 2024 19:02
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Oct 21, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 21, 2024

API change check

API changes are not detected in this pull request.

@ninghu
Copy link
Contributor Author

ninghu commented Oct 22, 2024

/check-enforcer override

@ninghu ninghu merged commit 3a43719 into main Oct 22, 2024
@ninghu ninghu deleted the ninhu/disable_target_snapshot branch October 22, 2024 21:01
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@ninghu @l0lawrence
Evaluation: Fix file being used by another process error during targe…
92a243d 
…t function execution (Azure#38021)

* Evaluation: Disable target snapshot upload by default

* update changlog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luigiw luigiw luigiw approved these changes

Assignees

No one assigned

Labels

Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ninghu @azure-sdk @luigiw