[Text Translation] Updating the SDK from the latest TypeSpec#35450
Merged
kristapratico merged 33 commits intoAzure:mainfrom May 21, 2024
MikeyMCZ:mimat/garf
Merged
[Text Translation] Updating the SDK from the latest TypeSpec#35450kristapratico merged 33 commits intoAzure:mainfrom MikeyMCZ:mimat/garf
kristapratico merged 33 commits intoAzure:mainfrom
MikeyMCZ:mimat/garf
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Please re-enable at least pylint here as well: https://github.com/Azure/azure-sdk-for-python/blob/dfe043657d227a1aa0c0a0f784e36b92b6bf83c9/sdk/translation/azure-ai-translation-text/pyproject.toml
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/__init__.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/_version.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/aio/_patch.py
Outdated
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/_patch.py
Outdated
Show resolved
Hide resolved
msyyc
reviewed
May 13, 2024
added 15 commits
May 13, 2024 11:47
Member
|
Overall looks good except CI fails: https://github.com/Azure/azure-sdk-for-python/pull/35450/checks?check_run_id=25122625367. There is detailed log and please fix it with those error info. |
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/_operations/_patch.py
Show resolved
Hide resolved
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/_patch.py
Show resolved
Hide resolved
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Looking good! Few small things
sdk/translation/azure-ai-translation-text/azure/ai/translation/text/_patch.py
Outdated
Show resolved
Hide resolved
…/text/_patch.py Co-authored-by: Krista Pratico <krpratic@microsoft.com>
kristapratico
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the SDK from the latest TypeSpec.