Skip to content

Conversation

@Lakicar95
Copy link
Contributor

@Lakicar95 Lakicar95 commented Mar 28, 2024

Description

This change will fix mypy typing errors for azure-maps-geolocation.

Current mypy version in tox.ini: mypy_version=1.6.1

Resolves: #32850

How it is tested?

azure-sdk-for-python\sdk\maps\azure-maps-geolocation> tox run -e mypy -c ../../../eng/tox/tox.ini --root .

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps labels Mar 28, 2024
@github-actions
Copy link

Thank you for your contribution @Lakicar95! We will review the pull request and get back to you soon.

Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lakicar95 looks great! Seeing as you fixed the typing in the samples as well, do you mind removing the type_check_samples=false from the pyproject.toml here? Thanks!

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/maps/azure-maps-geolocation/pyproject.toml#L3

@kristapratico kristapratico self-assigned this Mar 28, 2024
@Lakicar95
Copy link
Contributor Author

@Lakicar95 looks great! Seeing as you fixed the typing in the samples as well, do you mind removing the type_check_samples=false from the pyproject.toml here? Thanks!

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/maps/azure-maps-geolocation/pyproject.toml#L3

Thanks @kristapratico. Done. Also created PR for maps-render: #34987

@kristapratico
Copy link
Contributor

@Lakicar95 looks great! Seeing as you fixed the typing in the samples as well, do you mind removing the type_check_samples=false from the pyproject.toml here? Thanks!
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/maps/azure-maps-geolocation/pyproject.toml#L3

Thanks @kristapratico. Done. Also created PR for maps-render: #34987

Awesome! I'll approve/merge and take a look at the other PR soon :)

@kristapratico
Copy link
Contributor

/check-enforcer override

@kristapratico kristapratico merged commit c48ed46 into Azure:main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azure-maps-geolocation needs typing updates for mypy version 1.6.1

2 participants