[Monitor Query] Rename MetricsClient param#34760
Merged
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
force-pushed
the
query-resource-id
branch
2 times, most recently
from
32d20f0 to
66c56e4
Compare
pvaneck
requested review from
KarishmaGhiya,
gracewilcox,
jairmyree,
joshfree,
sarangan12,
scottaddie and
srnagar
This renames the `resource_uris` argument to `resource_ids` since this is the the preferred term that is used both in the Azure Portal and the metrics dataplane API. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
query-resource-id
branch
from
66c56e4 to
09b3ff8
Compare
xiangyan99
reviewed
Mar 15, 2024
xiangyan99
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the
resource_urisargument toresource_idsforMetricsClient.query_resourcessince this is the preferred term that is used both in the Azure Portal and the metrics dataplane API.Note: that in
MetricsQueryClient, the param nameresource_uriis used in the operations. This cannot be changed as this would be breaking.