[rest] allow files to accept a tuple with duplicate field names #34021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
annatisch,
johanste,
xiangyan99,
tjprescott and
kashifkhan
as code owners
|
API change check API changes are not detected in this pull request. |
msyyc
reviewed
Jan 26, 2024
lmazuel
reviewed
Jan 29, 2024
added 2 commits
January 29, 2024 13:10
kashifkhan
reviewed
Jan 29, 2024
kashifkhan
reviewed
Jan 29, 2024
added 2 commits
January 29, 2024 13:55
lmazuel
approved these changes
Jan 29, 2024
|
storage failure is unrelated, being resolved here: #34052. Force merging |
|
/check-enforcer override |
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-python
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we collapse the inputted
filesinto a dictionary after we apply our serialization onto it. That means if we have multiple inputs with the same field name, i.e.HttpRequest(files=[("file", filebytesOne), ("file", filebytesTwo)], we only passfiles={"file": filebytesTwo}to the transport and the service.In this PR, if users input a tuple to
files, we will maintain the tuple format. We're doing this so we don't completely move away from the request body's content being dictionary, as.contentis a public property