support tuples for files #33948
Merged
support tuples for files #33948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
annatisch,
johanste,
xiangyan99,
tjprescott and
kashifkhan
as code owners
lmazuel
reviewed
Jan 22, 2024
lmazuel
reviewed
Jan 22, 2024
lmazuel
reviewed
Jan 22, 2024
added 2 commits
January 22, 2024 18:01
|
API change check API changes are not detected in this pull request. |
xiangyan99
reviewed
Jan 23, 2024
sdk/core/azure-core/azure/core/utils/_pipeline_transport_rest_shared.py
Outdated
Show resolved
Hide resolved
added 2 commits
January 23, 2024 15:28
iscai-msft
commented
Jan 23, 2024
sdk/core/azure-core/azure/core/utils/_pipeline_transport_rest_shared.py
Outdated
Show resolved
Hide resolved
iscai-msft
commented
Jan 23, 2024
sdk/core/azure-core/azure/core/utils/_pipeline_transport_rest_shared.py
Outdated
Show resolved
Hide resolved
annatisch
reviewed
Jan 23, 2024
annatisch
reviewed
Jan 23, 2024
sdk/core/azure-core/azure/core/utils/_pipeline_transport_rest_shared.py
Outdated
Show resolved
Hide resolved
added 2 commits
January 23, 2024 17:37
iscai-msft
commented
Jan 23, 2024
xiangyan99
reviewed
Jan 24, 2024
iscai-msft
commented
Jan 24, 2024
iscai-msft
commented
Jan 24, 2024
sdk/core/azure-core/azure/core/utils/_pipeline_transport_rest_shared.py
Outdated
Show resolved
Hide resolved
added 4 commits
January 24, 2024 16:45
…into multipartTuples
…into multipartTuples
kashifkhan
approved these changes
Jan 25, 2024
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-python
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32566
Right now, you get an AttributeError if you try to pass in a tuple, and this service team needs to be able to pass in a tuple to modify the filename. This behavior is consistent with requests and httpx's, except that we don't add support for a tuple of 4 (which would be filename, file object, content type, other headers)