Skip to content

Conversation

@guptha23
Copy link
Contributor

@guptha23 guptha23 commented Feb 23, 2023

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@luigiw
Copy link
Contributor

luigiw commented Feb 23, 2023

We have a plan to switch job entity/operations to 2023-02-01-preview to support Singularity. Will 2023-02-01-preview serve the same purpose of this PR for AutoML? If yes, let's join the effort. @TonyJ1 FYI.

@TonyJ1
Copy link
Contributor

TonyJ1 commented Feb 23, 2023

We have a plan to switch job entity/operations to 2023-02-01-preview to support Singularity. Will 2023-02-01-preview serve the same purpose of this PR for AutoML? If yes, let's join the effort. @TonyJ1 FYI.

Thanks @luigiw!
Yes, please let us know if 2023-02-01-preview would work.

PR: [ML] Migrate from 2022_12_01_preview API to 2023_02_01_preview API

Dependency: MFE Release ETA: 02/28

@nmecklenburg
Copy link
Member

@guptha23
Copy link
Contributor Author

@guptha23 did you forget the tabular entities folder? ex: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/tabular/automl_tabular.py

sorry, I missed tabular entities folder before. I have updated the automl tabular entities folder now. can you please verify once? thank you!!

@nmecklenburg
Copy link
Member

I think with this all the automl entities have been covered -- but the CI gates are failing. Final step is ensuring they pass. I took a glance and a few were failing because we import sweep job entities (e.g. early termination policy) and those are still from Oct preview, so it looks like we'll need to upgrade the sweep imports as well at the very least.

@harneetvirk
Copy link
Contributor

Could you please update the changelog for the API version changes?

@novaturient95
Copy link
Member

novaturient95 commented Feb 27, 2023

is _job_operations not required to be updated? Its still pointing to October22?

Edit: its already updated to Dec API

@guptha23
Copy link
Contributor Author

guptha23 commented Feb 27, 2023

Could you please update the changelog for the API version changes?

have updated the changelog with the help of @MaurisLucis.

@harneetvirk can you please review once?

thank you!!

@harneetvirk harneetvirk merged commit a2db262 into Azure:main Feb 27, 2023
@rjaincc rjaincc self-requested a review February 28, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants