Skip to content

Comments

[AutoPR] recoveryservicesbackup/resource-manager#2799

Merged
lmazuel merged 4 commits intomasterfrom
restapi_auto_recoveryservicesbackup/resource-manager
Jun 27, 2018
Merged

[AutoPR] recoveryservicesbackup/resource-manager#2799
lmazuel merged 4 commits intomasterfrom
restapi_auto_recoveryservicesbackup/resource-manager

Conversation

@AutorestCI
Copy link
Contributor

Created to accumulate context: recoveryservicesbackup/resource-manager

@ghost
Copy link

ghost commented Jun 22, 2018

@lmazuel , Can you please check why the build here is failing? 'Version.py' seems to have the correct version - "0.2.0"

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jun 22, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-recoveryservicesbackup

You can install the package azure-mgmt-recoveryservicesbackup of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_recoveryservicesbackup/resource-manager#egg=azure-mgmt-recoveryservicesbackup&subdirectory=azure-mgmt-recoveryservicesbackup"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_recoveryservicesbackup/resource-manager#egg=azure-mgmt-recoveryservicesbackup&subdirectory=azure-mgmt-recoveryservicesbackup"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_recoveryservicesbackup/resource-manager
  • pip install -e ./azure-mgmt-recoveryservicesbackup

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_recoveryservicesbackup/resource-manager
  • pip wheel --no-deps ./azure-mgmt-recoveryservicesbackup

Direct download

Your files can be directly downloaded here:

@lmazuel
Copy link
Member

lmazuel commented Jun 22, 2018

Hi @frustoo2004
The version file was incorrect, that's what broke the CI.
Has your team or @DheerendraRathor planned to add test for the new features?
Thanks!

@DheerendraRathor
Copy link
Contributor

@lmazuel This PR mostly contains new models and there isn't much change in operations. For new models we'll add tests in future.
Existing tests are already covering changes in operations.

@lmazuel
Copy link
Member

lmazuel commented Jun 25, 2018

@DheerendraRathor sounds good. Anymore Swagger to come or you want a release asap?

@DheerendraRathor
Copy link
Contributor

@lmazuel I'm pretty sure no more updates coming in spec anytime soon. And we're good for release. Though we should wait to get green on C# pull request (Azure/azure-sdk-for-net#4488) as well.
@frustoo2004 Can you please provide release notes for this update?

@ghost
Copy link

ghost commented Jun 26, 2018

Release Notes- Python SDK - June 2018:

  • SAP HANA contract changes (new filters added to existing API's.). This feature is still in development phase and not open for usage yet.

  • Instant RP field added in create policy.

  • Comments added for some contracts.

@ghost
Copy link

ghost commented Jun 26, 2018

@lmazuel , Please check the release notes above and let me know if anything more needs to be added.

@lmazuel
Copy link
Member

lmazuel commented Jun 26, 2018

Hi @frustoo2004 , thanks for the ChangeLog!
I have made a tool to analyze PRs, and give me technical ChangeLog; Gives me that:

**Features**

- Model DPMProtectedItem has a new parameter create_mode
- Model MabFileFolderProtectedItem has a new parameter create_mode
- Model AzureIaaSClassicComputeVMProtectedItem has a new parameter create_mode
- Model AzureWorkloadContainer has a new parameter workload_type
- Model AzureIaaSVMProtectionPolicy has a new parameter instant_rp_retention_range_in_days
- Model AzureFileshareProtectedItem has a new parameter create_mode
- Model AzureSQLAGWorkloadContainerProtectionContainer has a new parameter workload_type
- Model AzureSqlProtectedItem has a new parameter create_mode
- Model AzureIaaSVMJobExtendedInfo has a new parameter internal_property_bag
- Model KeyAndSecretDetails has a new parameter encryption_mechanism
- Model AzureIaaSVMProtectedItem has a new parameter create_mode
- Model AzureVMAppContainerProtectionContainer has a new parameter workload_type
- Model AzureVmWorkloadSQLDatabaseProtectedItem has a new parameter create_mode
- Model IaasVMRecoveryPoint has a new parameter os_type
- Model ProtectionPolicyQueryObject has a new parameter workload_type
- Model AzureIaaSComputeVMProtectedItem has a new parameter create_mode
- Model Settings has a new parameter is_compression
- Model GenericProtectedItem has a new parameter create_mode
- Model AzureWorkloadJob has a new parameter workload_type
- Model ProtectedItem has a new parameter create_mode

**Breaking changes**

- Operation ProtectionContainersOperations.inquire has a new "filter" parameter

Do you feel it accurate with what you expect? Does it fit your ChangeLog?
Thanks!

@ghost
Copy link

ghost commented Jun 27, 2018

@lmazuel , Yes, the changelog published by you is in line with the summary published by me. Let me know if you need any more information

@lmazuel
Copy link
Member

lmazuel commented Jun 27, 2018

"push" failed for a know issue fixed on "master", but "pr" works (that's most important). Merging.

@lmazuel lmazuel merged commit 694158d into master Jun 27, 2018
@lmazuel lmazuel deleted the restapi_auto_recoveryservicesbackup/resource-manager branch June 27, 2018 21:35
@ghost
Copy link

ghost commented Jul 16, 2018

@lmazuel , C# SDK PR has been merged. Please check - Azure/azure-sdk-for-net#4488 . Can you please publish the Python SDK?

@lmazuel
Copy link
Member

lmazuel commented Jul 16, 2018

@frustoo2004 that was release the day of the merge as 0.3.0
https://pypi.org/project/azure-mgmt-recoveryservicesbackup/0.3.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants