Skip to content

Change default storage retention period to 48 hrs #26960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 2 commits into from
Oct 20, 2022
Merged

Change default storage retention period to 48 hrs #26960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed1e28
storage
lzchen Oct 20, 2022
01cdcd8
Update CHANGELOG.md
lzchen Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@
- Add validation logic to ApplicationInsightsSampler
([#26546](https://github.com/Azure/azure-sdk-for-python/pull/26546))
- Change default temporality of metrics to follow OTLP
([#26546](https://github.com/Azure/azure-sdk-for-python/pull/26546))
([#26924](https://github.com/Azure/azure-sdk-for-python/pull/26924))

### Breaking Changes

- Rename local storage configuration, change default path
([#26891](https://github.com/Azure/azure-sdk-for-python/pull/26891))
- Change default storage retention period to 48 hours
([#26960](https://github.com/Azure/azure-sdk-for-python/pull/26960))

### Bugs Fixed

Expand Down
2 changes: 1 addition & 1 deletion ...tor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def __init__(
path,
max_size=50 * 1024 * 1024, # 50MiB
maintenance_period=60, # 1 minute
retention_period=7 * 24 * 60 * 60, # 7 days
retention_period=48 * 60 * 60, # 48 hours
write_timeout=60, # 1 minute,
name=None,
lease_period=60, # 1 minute
Expand Down
2 changes: 1 addition & 1 deletion ...azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def __init__(self, **kwargs: Any) -> None:
tempfile.gettempdir(), _AZURE_TEMPDIR_PREFIX, _TEMPDIR_PREFIX + temp_suffix
)
self._storage_directory = kwargs.get('storage_directory', default_storage_directory) # Storage path in which to store retry files.
self._storage_retention_period = kwargs.get('storage_retention_period', 7 * 24 * 60 * 60) # Retention period in seconds
self._storage_retention_period = kwargs.get('storage_retention_period', 48 * 60 * 60) # Retention period in seconds (default 48 hrs)
self._timeout = kwargs.get('timeout', 10.0) # networking timeout in seconds

config = AzureMonitorClientConfiguration(self._endpoint, **kwargs)
Expand Down