Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@

from requests import Request, Response

from msrest import Deserializer

from azure.core.polling import async_poller, AsyncLROPoller
from azure.core.exceptions import DecodeError, HttpResponseError
from azure.core import AsyncPipelineClient
Expand Down
8 changes: 4 additions & 4 deletions sdk/core/azure-core/tests/async_tests/test_polling_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from azure.core import AsyncPipelineClient
from azure.core.polling import *
from azure.core.exceptions import ServiceResponseError
from msrest.serialization import Model
# from msrest.serialization import Model


@pytest.fixture
Expand Down Expand Up @@ -145,9 +145,9 @@ def deserialization_callback(response):
assert raw_poller.polling_method() is method
done_cb.assert_called_once_with(poller)

# Test with a basic Model
poller = AsyncLROPoller(client, initial_response, Model, method)
assert poller._polling_method._deserialization_callback == Model.deserialize
# # Test with a basic Model
Comment thread
xiangyan99 marked this conversation as resolved.
# poller = AsyncLROPoller(client, initial_response, Model, method)
# assert poller._polling_method._deserialization_callback == Model.deserialize

# Test poller that method do a run
method = PollingTwoSteps(sleep=1)
Expand Down
8 changes: 4 additions & 4 deletions sdk/core/azure-core/tests/test_polling.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
from azure.core.polling.base_polling import (
LROBasePolling, LocationPolling
)
from msrest.serialization import Model
# from msrest.serialization import Model


@pytest.fixture
Expand Down Expand Up @@ -181,9 +181,9 @@ def deserialization_callback(response):
assert poller.polling_method() is method
done_cb.assert_called_once_with(method)

# Test with a basic Model
poller = LROPoller(client, initial_response, Model, method)
assert poller._polling_method._deserialization_callback == Model.deserialize
# # Test with a basic Model
# poller = LROPoller(client, initial_response, Model, method)
# assert poller._polling_method._deserialization_callback == Model.deserialize

# Test poller that method do a run
method = PollingTwoSteps(sleep=1)
Expand Down
1 change: 1 addition & 0 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,6 @@
"azure-core<2.0.0,>=1.23.0",
"msrest>=0.6.21",
'six>=1.11.0',
"python-dateutil>=2.8.0"
Comment thread
xiangyan99 marked this conversation as resolved.
Outdated
],
)
3 changes: 2 additions & 1 deletion sdk/tables/azure-data-tables/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
install_requires=[
"azure-core<2.0.0,>=1.24.0",
"msrest>=0.7.1",
"yarl<2.0,>=1.0"
"yarl<2.0,>=1.0",
"python-dateutil>=2.8.0"
],
)