[Storage] Hotfix for empty file download through Azurite#26897
Merged
jalauzon-msft merged 5 commits intoAzure:hotfix/storage-empty-downloadfrom Oct 18, 2022
Merged
Conversation
jalauzon-msft
requested review from
annatisch and
vincenttran-msft
as code owners
ghost
added
the
Member
Author
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-storage-blob |
jalauzon-msft
changed the title
list_shares prefix issue
Member
Author
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vincenttran-msft
approved these changes
Oct 18, 2022
Member
vincenttran-msft
left a comment
vincenttran-msft
left a comment
There was a problem hiding this comment.
LGTM! That pesky 0, None, NULL, False mumbo jumbo that is usually handy in Python proved to not be so helpful here 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change cherry-picks two bug fixes from
maininto the hotfix branch for a patch release.ValueErroron empty blob download from Azurite for blob, datalake (calls into blob), and file-share.