Skip to content

[formrecognizer] Skip errors in live tests #26649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catalinaperalta merged 2 commits into from
Oct 20, 2022
Merged

[formrecognizer] Skip errors in live tests #26649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90aba23
add more error cases to skip decorator
catalinaperalta Oct 19, 2022
8ef04d8
update last case to catch invalidimage errors
catalinaperalta Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions sdk/formrecognizer/azure-ai-formrecognizer/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,18 @@
# license information.
# --------------------------------------------------------------------------

import logging
import pytest
from functools import wraps
from azure.core.exceptions import HttpResponseError
import sys
from devtools_testutils import add_remove_header_sanitizer, add_general_regex_sanitizer, add_oauth_response_sanitizer, add_body_key_sanitizer, test_proxy

# Ignore async tests for Python < 3.6
collect_ignore_glob = []
if sys.version_info < (3, 6):
collect_ignore_glob.append("*_async.py")
from devtools_testutils import (
add_remove_header_sanitizer,
add_general_regex_sanitizer,
add_oauth_response_sanitizer,
add_body_key_sanitizer,
test_proxy,
)

@pytest.fixture(scope="session", autouse=True)
def add_sanitizers(test_proxy):
Expand Down Expand Up @@ -67,6 +69,18 @@ def wrapper(*args, **kwargs):
try:
return f(*args, **kwargs)
except HttpResponseError as error:
logger = logging.getLogger("azure")
if "Invalid request".casefold() in error.message.casefold():
pytest.mark.skip("flaky service response")
pytest.mark.skip("flaky service response: {}".format(error))
logger.debug("flaky service response: {}".format(error))
elif "Generic error".casefold() in error.message.casefold():
pytest.mark.skip("flaky service response: {}".format(error))
logger.debug("flaky service response: {}".format(error))
elif "Timeout" in error.message.casefold():
pytest.mark.skip("flaky service response: {}".format(error))
logger.debug("flaky service response: {}".format(error))
elif "InvalidImage" in error.message.casefold():
pytest.mark.skip("flaky service response: {}".format(error))
logger.debug("flaky service response: {}".format(error))

return wrapper