Require newer azure-common version #2661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
|
|
Codecov Report
@@ Coverage Diff @@
## master #2661 +/- ##
=======================================
Coverage 55.88% 55.88%
=======================================
Files 7161 7161
Lines 150710 150710
=======================================
Hits 84228 84228
Misses 66482 66482Continue to review full report at Codecov.
|
lmazuel
reviewed
May 30, 2018
azure-mgmt-storage/setup.py
Outdated
Member
There was a problem hiding this comment.
Please remove this line that I already fixed on master and I will merge. Thanks!
The affected packages reference azure.profiles, which was added to azure-common in version 1.1.9. This updates their requirements accordingly.
ageorgou
force-pushed
the
update-common-version-req
branch
from
2103959 to
abca6ac
Compare
Contributor
Author
|
Rebased after recent changes to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2644. This tightens the dependencies for three packages, so that they now require a version of
azure-commonthat includesazure.profiles. More information in #2644.Sorry if this is already being worked on!