Skip to content

[ml] Disable SDK telemetries #26583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luigiw merged 13 commits into from
Oct 3, 2022
Merged

[ml] Disable SDK telemetries #26583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b9745c1
Disable SDK telemetries
luigiw Oct 1, 2022
798b4ee
pylint
luigiw Oct 1, 2022
a792a60
Remove from public interface
luigiw Oct 1, 2022
5e4204a
pylint
luigiw Oct 1, 2022
e03358f
ml_client
luigiw Oct 1, 2022
07d5ad9
consta
luigiw Oct 1, 2022
e670b09
remove logger
luigiw Oct 1, 2022
b817228
pylint
luigiw Oct 1, 2022
94c1dbe
pylint
luigiw Oct 3, 2022
d487939
Merge branch 'main' of https://github.com/luigiw/azure-sdk-for-python…
luigiw Oct 3, 2022
753ef2d
pylint
luigiw Oct 3, 2022
ba73160
pylint
luigiw Oct 3, 2022
76c764e
dummy
luigiw Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sdk/ml/azure-ai-ml/azure/ai/ml/_ml_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from azure.ai.ml._restclient.v2022_10_01_preview import AzureMachineLearningWorkspaces as ServiceClient102022Preview
from azure.ai.ml._restclient.v2022_10_01 import AzureMachineLearningWorkspaces as ServiceClient102022
from azure.ai.ml._scope_dependent_operations import OperationConfig, OperationsContainer, OperationScope
from azure.ai.ml._telemetry.logging_handler import get_appinsights_log_handler
from azure.ai.ml._user_agent import USER_AGENT
from azure.ai.ml._utils._http_utils import HttpPipeline
from azure.ai.ml._utils._registry_utils import RegistryDiscovery
Expand Down Expand Up @@ -198,7 +197,6 @@ def __init__(
kwargs.pop("base_url", None)
_add_user_agent(kwargs)

user_agent = None
properties = {
"subscription_id": subscription_id,
"resource_group_name": resource_group_name,
Expand All @@ -207,10 +205,13 @@ def __init__(
properties.update({"workspace_name": workspace_name})
if registry_name:
properties.update({"registry_name": registry_name})
if "user_agent" in kwargs:
user_agent = kwargs.get("user_agent")
app_insights_handler = get_appinsights_log_handler(user_agent, **{"properties": properties})
app_insights_handler_kwargs = {"app_insights_handler": app_insights_handler}

# user_agent = None
# if "user_agent" in kwargs:
# user_agent = kwargs.get("user_agent")
# app_insights_handler = get_appinsights_log_handler(user_agent, **{"properties": properties})
# app_insights_handler_kwargs = {"app_insights_handler": app_insights_handler}
app_insights_handler_kwargs = {}

base_url = _get_base_url_from_metadata(cloud_name=cloud_name, is_local_mfe=True)
self._base_url = base_url
Expand Down
16 changes: 8 additions & 8 deletions sdk/ml/azure-ai-ml/azure/ai/ml/_telemetry/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@

__path__ = __import__("pkgutil").extend_path(__path__, __name__)

from .activity import ActivityType, log_activity, monitor_with_activity, monitor_with_telemetry_mixin
from .logging_handler import AML_INTERNAL_LOGGER_NAMESPACE, get_appinsights_log_handler
# from .activity import ActivityType, log_activity, monitor_with_activity, monitor_with_telemetry_mixin
# from .logging_handler import AML_INTERNAL_LOGGER_NAMESPACE, get_appinsights_log_handler

__all__ = [
"monitor_with_activity",
"monitor_with_telemetry_mixin",
"log_activity",
"ActivityType",
"get_appinsights_log_handler",
"AML_INTERNAL_LOGGER_NAMESPACE",
# "monitor_with_activity",
# "monitor_with_telemetry_mixin",
# "log_activity",
# "ActivityType",
# "get_appinsights_log_handler",
# "AML_INTERNAL_LOGGER_NAMESPACE",
]
Loading