Skip to content

Added type annotation to the from_connection_string() method in _blob_service_client.py#26540

Closed
alherm7 wants to merge 1 commit intoAzure:mainfrom
alherm7:patch-1
Closed

Added type annotation to the from_connection_string() method in _blob_service_client.py#26540
alherm7 wants to merge 1 commit intoAzure:mainfrom
alherm7:patch-1

Conversation

@alherm7
Copy link

@alherm7 alherm7 commented Sep 29, 2022

This helps mypy detect the right class. Also it will help VS Code intellisense get the right code suggestions.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

This helps mypy detect the right class. Also it will help VS Code intellisense get the right code suggestions.
@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 29, 2022
@ghost
Copy link

ghost commented Sep 29, 2022

Thank you for your contribution alherm7! We will review the pull request and get back to you soon.

@jalauzon-msft
Copy link
Member

jalauzon-msft commented Oct 3, 2022

Hi @alherm7, thanks for your contribution! This is definitely a valid issue and something that we need to fix up. That being said, there are actually quite a few a places in the code where this needs to be adjusted so we should take care of all of them at once. Additionally, we'll need to tweak your change just a little since you are now mixing the two different styles of type hints.

Instead of asking you to do all this, I'll just go ahead and submit a change soon to fix this as well as the other instances of this issue. Thanks.

EDIT: Here's the PR #26611. It covers a bit of extra stuff but should cover this as well.

@jalauzon-msft
Copy link
Member

Closing this as its covered in #26611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants