Added type annotation to the from_connection_string() method in _blob_service_client.py#26540
Added type annotation to the from_connection_string() method in _blob_service_client.py#26540alherm7 wants to merge 1 commit intoAzure:mainfrom
Conversation
This helps mypy detect the right class. Also it will help VS Code intellisense get the right code suggestions.
|
Thank you for your contribution alherm7! We will review the pull request and get back to you soon. |
|
Hi @alherm7, thanks for your contribution! This is definitely a valid issue and something that we need to fix up. That being said, there are actually quite a few a places in the code where this needs to be adjusted so we should take care of all of them at once. Additionally, we'll need to tweak your change just a little since you are now mixing the two different styles of type hints. Instead of asking you to do all this, I'll just go ahead and submit a change soon to fix this as well as the other instances of this issue. Thanks. EDIT: Here's the PR #26611. It covers a bit of extra stuff but should cover this as well. |
|
Closing this as its covered in #26611. |
This helps mypy detect the right class. Also it will help VS Code intellisense get the right code suggestions.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines