Skip to content

Conversation

@zhengfeiwang
Copy link
Member

Description

Refine on_init/on_finalize feature from two aspects:

  1. fix bug when component's input does not have _data_binding
  2. ban on_init/on_finalize for PipelineComponent creation, raise error during dsl.pipeline, and change warning to error when validate.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang changed the title [ML] [ML] Refine on_init/on_finalize feature Sep 19, 2022
@zhengfeiwang zhengfeiwang changed the title [ML] Refine on_init/on_finalize feature [ML][Pipeline] Refine on_init/on_finalize Sep 27, 2022
@wangchao1230 wangchao1230 merged commit 7df1e36 into Azure:main Sep 27, 2022
@zhengfeiwang zhengfeiwang deleted the fix-init-finalize-bugs branch September 28, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants