-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[keyvault] Remove Python 3.6 and six references #26150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Dongwon Shin <ponopono0322@gmail.com>
|
Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon. |
mccoyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much again for doing this! Dropping six is a lot of work, and I really appreciate it 🙂 I'm sorry about the late review on this; there have been a number of releases in KV recently and it was difficult to merge things in while that was being worked on.
Based on your PR description, it sounds like we can close #25902 and use this PR instead. Is that correct?
|
By the way -- I'm currently regenerating our generated code, and that will drop the implicit |
|
Hi again @wonhyeongseo, I'm back! The code regeneration I mentioned earlier just went through today: #27170 If you update this PR with One last note: the Thank you again for the contribution and for your patience! |
|
Closing in favor of #27377 |
Description
Dear @mccoyp, after review we found some changes were lost during updates.
Thank you.
Is your feature request related to a problem? Please describe.
In accordance with the August Milestone of Azure for dropping Python 3.6 support, changes that were made to the keyvault packages have been recovered. We also recovered @ponopono0322's contribution of removing references to the
sixpackage.Describe the solution you'd like
Drop Python 3.6 support and add 3.10 to the supported versions list.
Remove all references of
sixpackage from keyvault code.Describe alternatives you've considered
None
Additional context
#25449
#25902
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines