Skip to content

Conversation

@kalyanaj
Copy link
Contributor

Regenerated EventGrid data plane SDK based to include new event types.

@kalyanaj kalyanaj requested a review from lmazuel May 22, 2018 23:14
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #2607 into master will increase coverage by <.01%.
The diff coverage is 62.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2607      +/-   ##
==========================================
+ Coverage   56.24%   56.24%   +<.01%     
==========================================
  Files        6434     6447      +13     
  Lines      140006   140130     +124     
==========================================
+ Hits        78743    78819      +76     
- Misses      61263    61311      +48
Impacted Files Coverage Δ
...id/models/iot_hub_device_created_event_data_py3.py 80% <100%> (ø) ⬆️
azure-eventgrid/azure/eventgrid/models/__init__.py 100% <100%> (ø) ⬆️
...container_registry_image_deleted_event_data_py3.py 80% <100%> (ø) ⬆️
.../azure/eventgrid/models/event_grid_client_enums.py 100% <100%> (ø)
azure-eventgrid/azure/eventgrid/version.py 100% <100%> (ø) ⬆️
.../container_registry_image_pushed_event_data_py3.py 80% <100%> (ø) ⬆️
...id/models/iot_hub_device_deleted_event_data_py3.py 80% <100%> (ø) ⬆️
...messages_available_with_no_listeners_event_data.py 36.36% <36.36%> (ø)
...ages_available_with_no_listeners_event_data_py3.py 36.36% <36.36%> (ø)
...messages_available_with_no_listeners_event_data.py 36.36% <36.36%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdb837...5fb80b0. Read the comment docs.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!

@lmazuel lmazuel merged commit 17d0603 into Azure:master May 25, 2018
@kalyanaj kalyanaj deleted the master branch August 21, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants