Skip to content

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Aug 2, 2022

Description

A few mypy.ini files across the repo are targeting Python 3.6, when they should target the most recent available version (3.10) instead. Discovered in #25449 (thanks, @wonhyeongseo!)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • Verifying updates with CI

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) App Configuration Azure.ApplicationModel.Configuration Search Cognitive - Form Recognizer Cognitive - Metrics Advisor Tables labels Aug 2, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 2, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-metricsadvisor
azure-search-documents

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mccoyp
Copy link
Member Author

mccoyp commented Aug 2, 2022

Tables CI failures are from a mindependency failure that should/will be fixed separately. Gonna override check enforcer on this one since the change isn't resulting in new failures.

@mccoyp
Copy link
Member Author

mccoyp commented Aug 2, 2022

/check-enforcer override

@mccoyp mccoyp merged commit 4a758e8 into Azure:main Aug 2, 2022
@mccoyp mccoyp deleted the mypy-ini branch August 2, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration Cognitive - Form Recognizer Cognitive - Metrics Advisor Search Storage Storage Service (Queues, Blobs, Files) Tables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants