Skip to content

[Cosmos] evaluation mistake in backwards compatibility #24633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 2 commits into from
May 27, 2022
Merged

[Cosmos] evaluation mistake in backwards compatibility #24633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b00dd0
Update container.py
simorenoh May 27, 2022
5040984
Update CHANGELOG.md
simorenoh May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/cosmos/azure-cosmos/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#### Breaking Changes

#### Bugs Fixed
- Fixed parsing of args for overloaded `container.read()` method.

#### Other Changes

Expand Down
4 changes: 2 additions & 2 deletions sdk/cosmos/azure-cosmos/azure/cosmos/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ def read(
"the populate_query_metrics flag does not apply to this method and will be removed in the future",
UserWarning,
)
populate_partition_key_range_statistics = args[1] if args and len(args) > 0 else kwargs.pop(
populate_partition_key_range_statistics = args[1] if args and len(args) > 1 else kwargs.pop(
"populate_partition_key_range_statistics", None)
populate_quota_info = args[2] if args and len(args) > 1 else kwargs.pop("populate_quota_info", None)
populate_quota_info = args[2] if args and len(args) > 2 else kwargs.pop("populate_quota_info", None)
if populate_partition_key_range_statistics is not None:
request_options["populatePartitionKeyRangeStatistics"] = populate_partition_key_range_statistics
if populate_quota_info is not None:
Expand Down