Skip to content

azure-core: ignore Connection header in tests, make tests pass with recent Flask + Werkzeug #24450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 1 commit into from
May 20, 2022
Merged

azure-core: ignore Connection header in tests, make tests pass with recent Flask + Werkzeug #24450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/core/azure-core/tests/async_tests/test_rest_headers_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

# flask returns these response headers, which we don't really need for these following tests
RESPONSE_HEADERS_TO_IGNORE = [
"Connection",
"Content-Type",
"Content-Length",
"Server",
Expand All @@ -24,7 +25,7 @@ async def _get_response_headers(request):
response = await client.send_request(request)
response.raise_for_status
for header in RESPONSE_HEADERS_TO_IGNORE:
response.headers.pop(header)
response.headers.pop(header, None)
return response.headers
return _get_response_headers

Expand Down
3 changes: 2 additions & 1 deletion sdk/core/azure-core/tests/test_rest_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def _get_request_headers(header_value):

# flask returns these response headers, which we don't really need for these following tests
RESPONSE_HEADERS_TO_IGNORE = [
"Connection",
"Content-Type",
"Content-Length",
"Server",
Expand All @@ -33,7 +34,7 @@ def _get_response_headers(request):
response = client.send_request(request)
response.raise_for_status
for header in RESPONSE_HEADERS_TO_IGNORE:
response.headers.pop(header)
response.headers.pop(header, None)
return response.headers
return _get_response_headers

Expand Down