[AutoPR] servicefabric/data-plane

[AutorestCI]

Created to accumulate context: servicefabric/data-plane

[AutorestCI]

(message created by the CI based on PR content)

Installation instruction

Package azure-servicefabric

You can install the package azure-servicefabric of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_servicefabric/data-plane#egg=azure-servicefabric&subdirectory=azure-servicefabric"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_servicefabric/data-plane#egg=azure-servicefabric&subdirectory=azure-servicefabric"

If you have a local clone of this repository, you can also do:

• git checkout restapi_auto_servicefabric/data-plane
• pip install -e ./azure-servicefabric

Or build a wheel file to distribute for testing:

• git checkout restapi_auto_servicefabric/data-plane
• pip wheel --no-deps ./azure-servicefabric

Direct download

Your files can be directly downloaded here:

• azure-servicefabric-6.2.0.0.zip
• azure_servicefabric-6.2.0.0-py2.py3-none-any.whl

[codecov-io]

Codecov Report

Merging #2445 into master will increase coverage by 2.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
+ Coverage   54.85%   56.99%   +2.13%     
==========================================
  Files        5552     6482     +930     
  Lines      129079   147005   +17926     
==========================================
+ Hits        70810    83784   +12974     
- Misses      58269    63221    +4952

Impacted Files	Coverage Δ
...s/v2017_05_10/operations/deployments_operations.py	64.51% <0%> (-31.94%)	⬇️
...source/resources/v2017_05_10/models/tag_details.py	68.75% <0%> (-31.25%)	⬇️
...resource/resources/v2017_05_10/models/tag_value.py	71.42% <0%> (-28.58%)	⬇️
...esources/v2017_05_10/models/deployment_extended.py	73.33% <0%> (-26.67%)	⬇️
...ure-mgmt-media/azure/mgmt/media/models/resource.py	73.33% <0%> (-26.67%)	⬇️
...017_05_10/operations/resource_groups_operations.py	71.55% <0%> (-26.04%)	⬇️
...azure/mgmt/media/models/sync_storage_keys_input.py	75% <0%> (-25%)	⬇️
...gmt-media/azure/mgmt/media/models/media_service.py	78.57% <0%> (-21.43%)	⬇️
...esource/resources/v2017_05_10/models/deployment.py	81.81% <0%> (-18.19%)	⬇️
...mgmt/media/models/check_name_availability_input.py	81.81% <0%> (-18.19%)	⬇️
... and 1803 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bf225...e054fc0. Read the comment docs.

[Christina-Kang]

@samedder is there anything we should be reviewing in here? Or is this ready to go and awaiting merge? thanks!

[samedder]

@Christina-Kang no I just mostly check that the changes look sane and it passes CI

[Christina-Kang]

@lmazuel Can you merge this in please? Thanks!

[Christina-Kang]

Ping @lmazuel Thanks! :)

[lmazuel]

@samedder @Christina-Kang This package is using the latest Autorest version (which is good), but you might have some additional work to adapt your current code base to it (just friendly warning).

Note that merge == release, so please past here a ChangeLog for the Python package, to update the HISTORY.txt file. Once I have the ChangeLog, I'm good to release your 6.2.0.0
Thanks!

Laurent

[samedder]

@lmazuel @Christina-Kang should let you know when it's release ready

[Christina-Kang]

@lmazuel What additional work are you referring to? Thanks! :) I'll have the changelog soon.

[Christina-Kang]

@lmazuel I've pasted the changelog below: Thanks! :)

6.2.0.0 (2018-05-10)
++++++++++++++++++++

Bugfixes

• Numerous fixes to descriptions and help text of entities

Features

• Add support for invoking container APIs
• Add option to fetch container logs from exited containers
• Query to get chaos events now supports specification to limit number of returned items

[lmazuel]

@Christina-Kang thanks for the ChangeLog!
I added to the ChangeLog the disclaimer for the new Autorest version. In many cases, this is backward compatible, but we removed some syntaxes that were error prone (better remove completely the ambiguous syntax that try to fix it with more ambiguous syntax....).

[Christina-Kang]

@lmazuel it seems like the python 3.5 build failed. This is the last jobs log I see $ curl -sSf -o python-3.5.tar.bz2 ${archive_url}. Is this something which indicates an error from some transient issue, or should I be looking into this? Similarly, there are two failures in the allowed failures portion. I doesn't seem to be related to this SDK at a cursory glance. Are these known issues?

Thanks! :)

[lmazuel]

@Christina-Kang Travis is in a bad mood today, but not related to the PR. I'm merging and releasing on PyPI now.

[lmazuel]

@Christina-Kang @samedder Released https://pypi.org/project/azure-servicefabric/6.2.0.0/

[Christina-Kang]

Thank you, @lmazuel :)