Skip to content

Comments

azure-digitaltwins-core prepare new release targeting api-version=2021-06-30-preview#23646

Merged
sjiherzig merged 8 commits intoAzure:release/digitaltwins/1.2.0bfrom
NateLehman:digitaltwins-core-prepare-release-2021-06-30-preview
Mar 29, 2022
Merged

azure-digitaltwins-core prepare new release targeting api-version=2021-06-30-preview#23646
sjiherzig merged 8 commits intoAzure:release/digitaltwins/1.2.0bfrom
NateLehman:digitaltwins-core-prepare-release-2021-06-30-preview

Conversation

@NateLehman
Copy link
Contributor

@NateLehman NateLehman commented Mar 24, 2022 •
edited
Loading

Description

Regenerate SDK based on new swagger spec introduced in #16963.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@NateLehman NateLehman marked this pull request as draft March 24, 2022 17:28
sjiherzig
sjiherzig requested changes Mar 25, 2022
View reviewed changes
Copy link
Member

@sjiherzig sjiherzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to set the target branch to release/digitaltwins/1.2.0b1

sjiherzig
sjiherzig reviewed Mar 25, 2022
View reviewed changes
@check-enforcer
Copy link

check-enforcer bot commented Mar 28, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@NateLehman NateLehman changed the base branch from main to release/digitaltwins/1.2.0b March 28, 2022 23:01
@NateLehman NateLehman changed the title Digitaltwins core prepare release 2021 06 30 preview azure-digitaltwins-core prepare new release targeting api-version=2021-06-30-preview Mar 28, 2022
@NateLehman NateLehman marked this pull request as ready for review March 28, 2022 23:04
@sjiherzig sjiherzig merged commit 21c320a into Azure:release/digitaltwins/1.2.0b Mar 29, 2022
sjiherzig pushed a commit that referenced this pull request Jul 8, 2022
@jeffyou543 @NateLehman @azure-sdk
Release/digitaltwins/1.2.0 (#24603)
822940e 
* azure-digitaltwins-core prepare new release targeting api-version=2021-06-30-preview (#23646)

* initial changes

* retargeted correct swagger and fix generation issue

* regenerate sdk and re-record with latest autorest

* remove bad test changes and tune tests to expect wus2

* attempt to fix new requirements

* fix analyze errors and update changelog

* remove unneeded sections from changelog

* Increment package version after release of azure-digitaltwins-core (#23770)

* Adding changes to support api-version 2022-05-31 for Digital Twins Data Plane SDK

Adding changes to support api-version 2022-05-31 for Digital Twins Data Plane SDK

Adding changes to support api-version 2022-05-31 for Digital Twins Data Plane SDK

Adding changes to support api-version 2022-05-31 for Digital Twins Data Plane SDK

Adding changes to support api-version 2022-05-31 for Digital Twins Data Plane SDK

Fixing prefix name

Correcting recordings

Updated Changelog with short description under 1.2.0

* Adding westus2 location for testing azuredigitaltwins

Co-authored-by: Nate Lehman <njlehman1@gmail.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjiherzig sjiherzig sjiherzig approved these changes

@johngallardo johngallardo Awaiting requested review from johngallardo

@Aashish93-stack-zz Aashish93-stack-zz Awaiting requested review from Aashish93-stack-zz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NateLehman @sjiherzig