[KeyVault] Updating KeyVaultAuthentication signed_session to support session reuse.#2345
Merged
schaabs merged 3 commits intoAzure:keyvault_1.0_previewfrom Apr 4, 2018
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
lmazuel
reviewed
Apr 4, 2018
| def signed_session(self): | ||
| session = requests.Session() | ||
| def signed_session(self, session=None): | ||
| session = session or super(KeyVaultAuthentication, self).signed_session() |
Member
There was a problem hiding this comment.
If you user super here, you need to restore the init call in the init (which I see is commented). Most simple here will be:
session = session or requests.Session()
Member
There was a problem hiding this comment.
Or change the base class to simply Authentication, since its init isn't doing anything (not like OAuthTokenAuthentication)
Codecov Report
@@ Coverage Diff @@
## keyvault_1.0_preview #2345 +/- ##
=====================================================
Coverage 54.46% 54.46%
=====================================================
Files 5407 5407
Lines 127479 127479
=====================================================
Hits 69429 69429
Misses 58050 58050
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.