Add bot service sdk to support microsoft.botservice#2328
Add bot service sdk to support microsoft.botservice#2328lmazuel merged 15 commits intoAzure:masterfrom swagatmishra2007:master
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
.pytest_cache/v/cache/lastfailed
Outdated
| @@ -0,0 +1,37 @@ | |||
| { | |||
There was a problem hiding this comment.
please remove this file from your PR
| channel_properties = channel | ||
| ) | ||
|
|
||
| # @ResourceGroupPreparer(name_prefix='pythonsdkbot') |
There was a problem hiding this comment.
the test is currently failing in live because of issues with skype and teams channel services. i plan to uncomment them once those services are fixed and i can run the test . Or would you rather have this removed and added in a separate pr?
| @@ -0,0 +1,178 @@ | |||
| from devtools_testutils import AzureMgmtTestCase, ResourceGroupPreparer | |||
| from azure.mgmt.botservice import AzureBotService | |||
| from azure.mgmt.botservice.models import Bot, BotProperties,sku,BotChannel,ErrorException | |||
| def tearDown(self): | ||
| super(BotServiceChannelsTestCase, self).tearDown() | ||
| self.client.bots.delete( | ||
| resource_group_name = self.resource_group_name, |
There was a problem hiding this comment.
you don't need that, that's the role of the preparer
There was a problem hiding this comment.
i dont have a bot preparer right now. i will add one in my next review when i enable the skype, teams tests.
Codecov Report
@@ Coverage Diff @@
## master #2328 +/- ##
==========================================
+ Coverage 52.81% 52.91% +0.09%
==========================================
Files 5670 5719 +49
Lines 134499 135213 +714
==========================================
+ Hits 71034 71542 +508
- Misses 63465 63671 +206
Continue to review full report at Codecov.
|
4 participants
the swagger is at - https://github.com/Azure/azure-rest-api-specs/tree/master/specification/botservice/resource-manager
i have added tests for most of the channels. only directline, msteams and skype are disabled due to the main service having a bug, which prevents me from running the tests live.
i will add those in soon, but i need to merge in the python sdk first, as my cli sdk PR depends on this.