Skip to content

Improve except #23168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakshith91 merged 3 commits into from
Feb 23, 2022
+2 −2
Merged

Improve except #23168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
467e570
Improve except
rakshith91 Feb 22, 2022
19bab31
Update sdk/monitor/azure-monitor-query/azure/monitor/query/_helpers.py
rakshith91 Feb 22, 2022
ea7acf7
Apply suggestions from code review
rakshith91 Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-query/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## 1.0.2 (Unreleased)

- This version and all future versions will require Python 3.7+. Python 2.7 and 3.6 are no longer supported.
- This version and all future versions will require Python 3.6+. Python 2.7 and 3.6 are no longer supported.
Comment thread
rakshith91 marked this conversation as resolved.
Outdated

### Bugs Fixed

Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-query/azure/monitor/query/_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def native_col_type(col_type, value):
if col_type == "datetime":
try:
value = Deserializer.deserialize_iso(value)
except: # pylint: disable=bare-except
except Exception: # pylint: disable=bare-except
Comment thread
rakshith91 marked this conversation as resolved.
Outdated
# if there is any exception in deserializing the iso,
# return the value to the user
pass
Expand Down