Skip to content

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Feb 17, 2022

Description

This pipeline error is coming up when we attempt to run git rev-parse HEAD via subprocess, but it turns out that we don't use the result anyway. Removing this call. @scbedd

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • N/A Pull request includes test coverage for the included changes.
    • Using affected pipelines

@mccoyp
Copy link
Member Author

mccoyp commented Feb 17, 2022

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mccoyp
Copy link
Member Author

mccoyp commented Feb 17, 2022

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mccoyp
Copy link
Member Author

mccoyp commented Feb 17, 2022

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mccoyp mccoyp marked this pull request as ready for review February 18, 2022 00:00
@mccoyp mccoyp merged commit 5c6e49b into Azure:main Feb 18, 2022
@mccoyp mccoyp deleted the proxy-subprocess branch February 18, 2022 00:01
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (601 commits)
  pin markupsafe (Azure#23132)
  [Communication] - phone-numbers - Implement a phone number pool for update capabilities live tests (Azure#23116)
  Add timeout on Invoke-request call (Azure#23120)
  Sync eng/common directory with azure-sdk-tools for PR 2775 (Azure#23115)
  Update aggregate-report to use common credscan yml and update baseline file (Azure#23090)
  Update CHANGELOG.md (Azure#23119)
  [Issue helper] Update owner list (Azure#23079)
  [KV] Update changelogs for stable releases (Azure#23053)
  code and test (Azure#23047)
  [recoveryservicesbackup] fix multiple pages paging (Azure#23089)
  rerecord failing tests for fr (Azure#23107)
  [Test Proxy] Remove unnecessary git SHA fetch (Azure#23113)
  [Storage] Fix some mypy typing errors and typing imports (Azure#23098)
  Add logic to generate docs.ms ToC (Azure#23086)
  Fix broken link in tests.md (Azure#23110)
  Enable apistub gen step (Azure#23088)
  pin version of storage blob used for testing (Azure#23109)
  ensure that py36 can start the process properly (Azure#23108)
  fix cspell issues for azure-communication identity (Azure#22636) (Azure#23085)
  code and test (Azure#23077)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants