Skip to content

[formrecognizer] Adding 2022-01-30-preview work#22912

Merged
catalinaperalta merged 2 commits intoAzure:mainfrom
catalinaperalta:addFR2022-01-30-preview
Feb 4, 2022
Merged

[formrecognizer] Adding 2022-01-30-preview work#22912
catalinaperalta merged 2 commits intoAzure:mainfrom
catalinaperalta:addFR2022-01-30-preview

Conversation

@catalinaperalta
Copy link
Member

This PR is moving the 2022-01-30-preview work checked into the private repo into main.

@catalinaperalta
Copy link
Member Author

/azp run python - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@catalinaperalta catalinaperalta marked this pull request as ready for review February 4, 2022 00:49
Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all work was already reviewed on the private repo 🐰

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-ai-formrecognizer. You can review API changes here

@check-enforcer
Copy link

check-enforcer bot commented Feb 4, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@catalinaperalta
Copy link
Member Author

/azp run python - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@catalinaperalta
Copy link
Member Author

For the live test pipeline results, the following samples are failing because they are missing the build_mode parameter:
'sample_create_composed_model.py', 'sample_manage_models.py', 'sample_create_composed_model_async.py', 'sample_manage_models_async.py'
This needs to fix the path to the sample file: 'sample_analyze_read_async.py'

Will merge and fix in the next PR.

@catalinaperalta catalinaperalta merged commit d4d12b9 into Azure:main Feb 4, 2022
@catalinaperalta catalinaperalta deleted the addFR2022-01-30-preview branch February 4, 2022 17:35
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* adding FR 2022-01-30-preview work

* update shared requirements
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants