Skip to content

[Communication] - phone-numbers - Skip update capabilities tests #22911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whisper6284 merged 2 commits into from
Feb 8, 2022
Merged

[Communication] - phone-numbers - Skip update capabilities tests #22911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d982b72
Skip update capabilities live test
danielortega-msft Feb 4, 2022
a57d1fb
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
danielortega-msft Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...nication/azure-communication-phonenumbers/test/test_phone_number_administration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
SKIP_INT_PHONE_NUMBER_TESTS = os.getenv("COMMUNICATION_SKIP_INT_PHONENUMBERS_TEST", "false") == "true"
INT_PHONE_NUMBER_TEST_SKIP_REASON = "Phone numbers setting SMS capability does not support in INT. Skip these tests in INT."

SKIP_UPDATE_CAPABILITIES_TESTS = os.getenv("COMMUNICATION_SKIP_CAPABILITIES_LIVE_TEST", "false") == "true"
SKIP_UPDATE_CAPABILITIES_TESTS_REASON = "Phone number capabilities update does not currently support parallel execution. Skip these tests from live test pipeline."

class PhoneNumbersClientTest(CommunicationTestCase):
def setUp(self):
super(PhoneNumbersClientTest, self).setUp()
Expand Down Expand Up @@ -110,6 +113,7 @@ def test_search_available_phone_numbers(self):
assert poller.result()

@pytest.mark.skipif(SKIP_INT_PHONE_NUMBER_TESTS, reason=INT_PHONE_NUMBER_TEST_SKIP_REASON)
@pytest.mark.skipif(SKIP_UPDATE_CAPABILITIES_TESTS, reason=SKIP_UPDATE_CAPABILITIES_TESTS_REASON)
def test_update_phone_number_capabilities_from_managed_identity(self):
endpoint, access_key = parse_connection_str(self.connection_str)
credential = create_token_credential()
Expand All @@ -131,6 +135,7 @@ def test_update_phone_number_capabilities_from_managed_identity(self):
assert poller.status() == PhoneNumberOperationStatus.SUCCEEDED.value

@pytest.mark.skipif(SKIP_INT_PHONE_NUMBER_TESTS, reason=INT_PHONE_NUMBER_TEST_SKIP_REASON)
@pytest.mark.skipif(SKIP_UPDATE_CAPABILITIES_TESTS, reason=SKIP_UPDATE_CAPABILITIES_TESTS_REASON)
def test_update_phone_number_capabilities(self):
current_phone_number = self.phone_number_client.get_purchased_phone_number(self.phone_number)
calling_capabilities = PhoneNumberCapabilityType.INBOUND if current_phone_number.capabilities.calling == PhoneNumberCapabilityType.OUTBOUND else PhoneNumberCapabilityType.OUTBOUND
Expand Down
5 changes: 5 additions & 0 deletions ...on/azure-communication-phonenumbers/test/test_phone_number_administration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
SKIP_INT_PHONE_NUMBER_TESTS = os.getenv("COMMUNICATION_SKIP_INT_PHONENUMBERS_TEST", "false") == "true"
INT_PHONE_NUMBER_TEST_SKIP_REASON = "Phone numbers setting SMS capability does not support in INT. Skip these tests in INT."

SKIP_UPDATE_CAPABILITIES_TESTS = os.getenv("COMMUNICATION_SKIP_CAPABILITIES_LIVE_TEST", "false") == "true"
SKIP_UPDATE_CAPABILITIES_TESTS_REASON = "Phone number capabilities update does not currently support parallel execution. Skip these tests from live test pipeline."

class PhoneNumbersClientTestAsync(AsyncCommunicationTestCase):
def setUp(self):
super(PhoneNumbersClientTestAsync, self).setUp()
Expand Down Expand Up @@ -129,6 +132,7 @@ async def test_search_available_phone_numbers(self):
assert poller.result()

@pytest.mark.skipif(SKIP_INT_PHONE_NUMBER_TESTS, reason=INT_PHONE_NUMBER_TEST_SKIP_REASON)
@pytest.mark.skipif(SKIP_UPDATE_CAPABILITIES_TESTS, reason=SKIP_UPDATE_CAPABILITIES_TESTS_REASON)
@AsyncCommunicationTestCase.await_prepared_test
async def test_update_phone_number_capabilities(self):
async with self.phone_number_client:
Expand All @@ -145,6 +149,7 @@ async def test_update_phone_number_capabilities(self):
assert poller.status() == PhoneNumberOperationStatus.SUCCEEDED.value

@pytest.mark.skipif(SKIP_INT_PHONE_NUMBER_TESTS, reason=INT_PHONE_NUMBER_TEST_SKIP_REASON)
@pytest.mark.skipif(SKIP_UPDATE_CAPABILITIES_TESTS, reason=SKIP_UPDATE_CAPABILITIES_TESTS_REASON)
@AsyncCommunicationTestCase.await_prepared_test
async def test_update_phone_number_capabilities_from_managed_identity(self):
endpoint, access_key = parse_connection_str(self.connection_str)
Expand Down
2 changes: 2 additions & 0 deletions sdk/communication/azure-communication-phonenumbers/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@ stages:
- $(sub-config-communication-int-test-resources-common)
- $(sub-config-communication-int-test-resources-python)
Clouds: Public,Int
EnvVars:
COMMUNICATION_SKIP_CAPABILITIES_LIVE_TEST: true