[formrecognizer] Add a default for percent_completed #22790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
catalinaperalta
requested review from
iscai-msft and
kristapratico
as code owners
kristapratico
approved these changes
Jan 26, 2022
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py
Show resolved
Hide resolved
|
Hello @catalinaperalta! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Default percent_completed to 0. After talking to the service team, this should be defaulted to 0 when not returned. Generally our tests fail with operations that have a `notStarted` status since this is currently not returning a percent_completed value.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default percent_completed to 0. After talking to the service team, this should be defaulted to 0 when not returned. Generally our tests fail with operations that have a
notStartedstatus since this is currently not returning a percent_completed value.