Skip to content

Conversation

@marcusc2
Copy link
Contributor

This PR will:

  • mark test_compress_compressed_no_header() as live test only
  • create test_compress_compressed_no_header_offline()
  • add stream_compress() and compress() in streams.py to replicate online test behavior

Please disregard the previous PR

@ghost ghost added Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 21, 2022
@ghost
Copy link

ghost commented Jan 21, 2022

Thank you for your contribution marcusc2! We will review the pull request and get back to you soon.

@catalinaperalta catalinaperalta added the Impact++ This pull request was submitted by a member of the Impact++ team. label Jan 21, 2022
@check-enforcer
Copy link

check-enforcer bot commented Feb 3, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@kristapratico
Copy link
Contributor

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! i worry that by catching the HttpResponseError we're swallowing potential errors that we shouldn't be having. Thanks!

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Do we need an async test too?

Or we plan to add it in a separate PR?

Thanks.

@iscai-msft iscai-msft enabled auto-merge (squash) May 3, 2022 00:00
@iscai-msft iscai-msft merged commit 4193b66 into Azure:main May 3, 2022
@marcusc2 marcusc2 deleted the 9324/test_streaming.py-create-test_compress_compressed_no_header_offline/mc-impact branch June 28, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. Impact++ This pull request was submitted by a member of the Impact++ team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants