-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Issue #9324 create test_compress_compressed_no_header_offline #22624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #9324 create test_compress_compressed_no_header_offline #22624
Conversation
|
Thank you for your contribution marcusc2! We will review the pull request and get back to you soon. |
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Outdated
Show resolved
Hide resolved
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Outdated
Show resolved
Hide resolved
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! i worry that by catching the HttpResponseError we're swallowing potential errors that we shouldn't be having. Thanks!
xiangyan99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
Do we need an async test too?
Or we plan to add it in a separate PR?
Thanks.
This PR will:
Please disregard the previous PR