[textanalytics] switch to kwargs where we run nonrecorded tests#22614
Merged
kristapratico merged 2 commits intoAzure:mainfrom Jan 21, 2022
Merged
[textanalytics] switch to kwargs where we run nonrecorded tests#22614kristapratico merged 2 commits intoAzure:mainfrom
kristapratico merged 2 commits intoAzure:mainfrom
Conversation
iscai-msft
approved these changes
Jan 21, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
…e#22614) * switch to kwargs where we run nonrecorded tests * remove unused import
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't want to record a test, we omit the @recorded_by_proxy decorator. However, this decorator allows the test params be passed as actual params, whereas in its absence, pytest treats any params as fixtures. Moving test params to kwargs for unrecorded tests fixes the issue. Thanks @mccoyp for the help!