Skip to content

[Test Proxy] Normalize paths in test IDs #22508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mccoyp merged 2 commits into from
Jan 14, 2022
Merged

[Test Proxy] Normalize paths in test IDs #22508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f588fd7
Normalize paths in test IDs
mccoyp Jan 14, 2022
bfb4a76
Revert create_random_name
mccoyp Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions tools/azure-sdk-tools/devtools_testutils/proxy_testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,21 @@ def get_recording_id():
def get_test_id():
# type: () -> str
# pytest sets the current running test in an environment variable
# the path to the test can depend on the environment, so we can't assume this is the path from the repo root
setting_value = os.getenv("PYTEST_CURRENT_TEST")

path_to_test = os.path.normpath(setting_value.split(" ")[0])
path_components = path_to_test.split(os.sep)

full_path_to_test = os.path.abspath(path_to_test)

# walk up to the repo root by looking for "sdk" directory or root of file system
path_components = []
head, tail = os.path.split(full_path_to_test)
while tail != "sdk" and tail != "":
Copy link
Member

@scbedd scbedd Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have any other stop cases here. Famous last words 👍

Copy link
Member Author

@mccoyp mccoyp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing a while loop always terrifies me, but I'm also pretty sure this should be good. Knocking furiously on wood

path_components.append(tail)
head, tail = os.path.split(head)

# reverse path_components to construct components of path from repo root: [sdk, ..., tests, {test}]
path_components.append("sdk")
path_components.reverse()
for idx, val in enumerate(path_components):
if val.startswith("test"):
path_components.insert(idx + 1, "recordings")
Expand Down