-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Enforce py3 wheels only in CI #22225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR will probably be green, but we should not merge immediately until we're ready for errrors to start popping up. This PR will be green because |
|
Just a reminder. This PR should only be merged when we are ready to flip Once those are fixed, a requeued check should come back green. |
|
Hi @scbedd. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @scbedd. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
@lmazuel This is the "hard" break on py27.
It extends the
verifywhltox environment to do the additional following checks.python_requiresis present on your setup.py, it will error.python_requiresis defined, and is not>= 3.0, it will error.python_requiresis defined and set at something>= 3.0, but asetup.cfgis still present with auniversal=1config key, it will error.All of the above are skippable by environment variable
IGNORE_WHEEL_PYVERSION_CHECK.We can merge this PR whenever we want this to start hard erroring on py2 packages. Once that's clean, I can easily submit a PR to remove py2.7 from the build matrix.