Skip to content

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Dec 17, 2021

Description

Context: some azure-keyvault-administration tests, such as test_full_backup_and_restore, have been failing in live tests because of InternalServerErrors relating to SAS tokens. The last time this happened, it was because the lifetime of our test SAS tokens was too short.

Extending the lifetime of our tokens didn't fix things this time around, so I followed JS's approach of outputting a SAS token during test resource creation instead of creating one manually. Our prior methodology for creating tokens has apparently become invalid, presumably because of service-side changes.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Dec 17, 2021
@mccoyp
Copy link
Member Author

mccoyp commented Dec 17, 2021

/azp run python - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp
Copy link
Member Author

mccoyp commented Dec 18, 2021

/azp run python - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp mccoyp changed the title [Key Vault] Extend SAS token lifetimes in admin tests [Key Vault] Create SAS token env var during test resource deployment Dec 18, 2021
@mccoyp
Copy link
Member Author

mccoyp commented Dec 20, 2021

/azp run python - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp
Copy link
Member Author

mccoyp commented Feb 18, 2022

This has been hanging around for a while; closing.

@mccoyp mccoyp closed this Feb 18, 2022
@mccoyp mccoyp deleted the kv-sas branch March 15, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant