[Key Vault] Update HSM deployment scripts #22179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
Member
Author
|
/azp run python - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mccoyp
requested review from
YalinLi0312,
chlowell and
schaabs
as code owners
Member
Author
|
@benbp There are some |
benbp
reviewed
Dec 15, 2021
sdk/keyvault/test-resources.json
Outdated
| "hsmLocation": { | ||
| "type": "string", | ||
| "defaultValue": "westus", | ||
| "defaultValue": "canadacentral", |
Member
There was a problem hiding this comment.
We will still pass in westus2 as the default in the deployment scripts unless an override is specified in tests.yml
benbp
approved these changes
Dec 15, 2021
Member
Author
|
/azp run python - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/check-enforcer override |
hildurhodd
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Jan 4, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSM deployments have been stalling during live test pipelines for the past week. Discussion of the issue can be found in #21717.