[translation] remove sample tests dependency on static storage acc #21992
Conversation
|
Hey @benbp wanted to get your opinion on this PR. I want to add the Dogfood config to translation live tests, but realized that we currently have a static storage account defined in the test-resources.json which is used to run samples in the CI. All we really need to run samples successfully are two small files which exist locally in the repo. I'm wondering if this is appropriate usage of the test-resources-post.ps1 step to just upload these files to the container created in the template so we can run samples and then tear everything down at the end. Let me know if there is another way you would recommend over this approach. |
|
This is great. I'm totally behind removing static resources in favor of a reproducible/cloud independent approach. The post script is the right place to do this. |
…azure-sdk-for-python into revert_error_logging * 'revert_error_logging' of https://github.com/iscai-msft/azure-sdk-for-python: Sync eng/common directory with azure-sdk-tools for PR 2327 (Azure#22021) Sync eng/common directory with azure-sdk-tools for PR 2327 (Azure#22017) pin mistune, dep of m2r, after breaking change release (Azure#22018) Update eng sys codeowners [AutoRelease] t2-loadtestservice-2021-11-26-84683 (Azure#21895) update release-helper (Azure#22012) skip python ci for data-plane (Azure#22011) CognitiveServices Face (Azure#21986) [stress, eventhub] Update dependency version and image/namespace. Remove redundant files. (Azure#21989) [translation] remove sample tests dependency on static storage acc (Azure#21992) Update packaging tool only (Azure#21973) Increment package version after release of azure-core (Azure#21991) Sync eng/common directory with azure-sdk-tools for PR 2380 (Azure#21993) pin crypto in depends check (Azure#21987) Restore deploymentOutputs variable in scope for post deployment script (Azure#21983)
…zure#21992) * try post resources script * remove excess pwsh script * fix source container permissions
The sample tests for Document Translation depend on a persistent storage account which needs a container with two small files to test the scenarios in the live CI. We originally were using a static storage account for this in the test-resources.json, but I want to fix this because...
The rest of the resources and containers needed for tests/samples can be be dynamically created and torn down as expected.
Live test run pass: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1226274&view=results