Skip to content

[QnA] Made operations groups internal #21477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annatisch merged 2 commits into from
Oct 28, 2021
Merged

[QnA] Made operations groups internal #21477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84ec11a
Made operations private
annatisch Oct 28, 2021
b37e70b
Updated changelog
annatisch Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/cognitivelanguage/azure-ai-language-questionanswering/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
* Model property `AnswerSpan.confidence_score` has been renamed to `AnswerSpan.confidence`
* Model property `TextAnswer.confidence_score` has been renamed to `TextAnswer.confidence`
* Model property `TextAnswer.answer_span` has been renamed to `TextAnswer.short_answer`
* Enums `LogicalOperationKind` and `RankerType` have been removed.
* Enums `LogicalOperationKind` and `RankerType` have been removed
* The `operations` and `aio.operations` namespaces are no longer public

### Bugs Fixed

Expand Down
0 ...stionanswering/aio/operations/__init__.py → ...questionanswering/_operations/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...estionanswering/operations/_operations.py → ...stionanswering/_operations/_operations.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...guage-questionanswering/azure/ai/language/questionanswering/_question_answering_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from . import models
from ._configuration import QuestionAnsweringClientConfiguration
from .operations import QuestionAnsweringClientOperationsMixin
from ._operations import QuestionAnsweringClientOperationsMixin

if TYPE_CHECKING:
# pylint: disable=unused-import,ungrouped-imports
Expand Down
0 .../questionanswering/operations/__init__.py → ...tionanswering/aio/_operations/__init__.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...onanswering/aio/operations/_operations.py → ...nanswering/aio/_operations/_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from azure.core.tracing.decorator_async import distributed_trace_async

from ... import models as _models
from ...operations._operations import build_get_answers_from_text_request, build_get_answers_request
from ..._operations._operations import build_get_answers_from_text_request, build_get_answers_request
from ..._patch import (
_validate_text_records,
_get_positional_body,
Expand Down
2 changes: 1 addition & 1 deletion ...e-questionanswering/azure/ai/language/questionanswering/aio/_question_answering_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

from .. import models
from ._configuration import QuestionAnsweringClientConfiguration
from .operations import QuestionAnsweringClientOperationsMixin
from ._operations import QuestionAnsweringClientOperationsMixin


class QuestionAnsweringClient(QuestionAnsweringClientOperationsMixin):
Expand Down
2 changes: 1 addition & 1 deletion sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
)

from azure.ai.language.questionanswering import QuestionAnsweringClient
from azure.ai.language.questionanswering.operations._operations import build_get_answers_request
from azure.ai.language.questionanswering._operations._operations import build_get_answers_request
from azure.ai.language.questionanswering.models import (
AnswersOptions,
KnowledgeBaseAnswerContext,
Expand Down
2 changes: 1 addition & 1 deletion ...itivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
MetadataFilter,
)
from azure.ai.language.questionanswering.aio import QuestionAnsweringClient
from azure.ai.language.questionanswering.operations._operations import build_get_answers_request
from azure.ai.language.questionanswering._operations._operations import build_get_answers_request


class QnAKnowledgeBaseTestsAsync(AsyncQuestionAnsweringTest):
Expand Down
2 changes: 1 addition & 1 deletion sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
)

from azure.ai.language.questionanswering import QuestionAnsweringClient
from azure.ai.language.questionanswering.operations._operations import build_get_answers_from_text_request
from azure.ai.language.questionanswering._operations._operations import build_get_answers_from_text_request
from azure.ai.language.questionanswering.models import (
AnswersFromTextOptions,
TextDocument
Expand Down
2 changes: 1 addition & 1 deletion sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_text_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
)

from azure.ai.language.questionanswering.aio import QuestionAnsweringClient
from azure.ai.language.questionanswering.operations._operations import build_get_answers_from_text_request
from azure.ai.language.questionanswering._operations._operations import build_get_answers_from_text_request
from azure.ai.language.questionanswering.models import (
AnswersFromTextOptions,
TextDocument
Expand Down