Skip to content

Bit more complicated parsing of the requirements_to_exclude during install_depend_packages.py #21459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 4 commits into from
Oct 28, 2021
Merged

Bit more complicated parsing of the requirements_to_exclude during install_depend_packages.py #21459

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e5b071
we do a little bit more work to filter out packages now
scbedd Oct 27, 2021
30f1007
add docstring to check_req_against_exclusion
scbedd Oct 28, 2021
43b4ecd
small docstring update
scbedd Oct 28, 2021
38b0475
specifiers
scbedd Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion eng/tox/install_depend_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import logging
from packaging.specifiers import SpecifierSet
from pkg_resources import Requirement, parse_version
import re

from pypi_tools.pypi import PyPIClient

Expand Down Expand Up @@ -121,6 +122,17 @@ def process_requirement(req, dependency_type):
return ""


def check_req_against_exclusion(req, req_to_exclude):
req_id = ''
for c in req:
if re.match(r"[A-Za-z0-9_-]", c):
req_id += c
else:
break

return req_id == req_to_exclude


def filter_dev_requirements(setup_py_path, released_packages, temp_dir):
# This method returns list of requirements from dev_requirements by filtering out packages in given list
dev_req_path = os.path.join(os.path.dirname(setup_py_path), DEV_REQ_FILE)
Expand All @@ -140,7 +152,7 @@ def filter_dev_requirements(setup_py_path, released_packages, temp_dir):
filtered_req = [
req
for req in requirements
if os.path.basename(req.replace('\n', '')) not in req_to_exclude and not any([req.startswith(i) for i in req_to_exclude])
if os.path.basename(req.replace('\n', '')) not in req_to_exclude and not any([check_req_against_exclusion(req, i) for i in req_to_exclude])
]

logging.info("Filtered dev requirements: %s", filtered_req)
Expand Down