Skip to content

[Key Vault] Remove redundant resource group allocation in tests #21452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mccoyp wants to merge 3 commits into from
Closed

[Key Vault] Remove redundant resource group allocation in tests #21452

mccoyp wants to merge 3 commits into from

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Oct 27, 2021

See #21414.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Oct 27, 2021
@mccoyp
Copy link
Member Author

mccoyp commented Oct 27, 2021

/azp run python - keyvault - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 27, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp mccoyp marked this pull request as ready for review October 27, 2021 21:18
@mccoyp mccoyp requested a review from benbp as a code owner October 27, 2021 21:18
@benbp
Copy link
Member

benbp commented Oct 27, 2021

Can sdk/keyvault/azure-mgmt-keyvault/tests.yml be set to false as well?

@benbp
Copy link
Member

benbp commented Oct 27, 2021

If this change is working I think we can fully retire this parameter: #21458

@mccoyp
Copy link
Member Author

mccoyp commented Oct 27, 2021

azure-mgmt-keyvault doesn't seem to use a test-resources.json file -- would it still be okay without the parameter? I can also try adding that change here

@mccoyp mccoyp requested review from RAY-316 and msyyc as code owners October 27, 2021 22:18
@mccoyp
Copy link
Member Author

mccoyp commented Oct 27, 2021

Unfortunately the only azure-mgmt-keyvault pipeline we seem to run regularly isn't configured to regularly pass: https://dev.azure.com/azure-sdk/internal/_build?definitionId=2503&_a=summary

@mccoyp
Copy link
Member Author

mccoyp commented Oct 27, 2021

/azp run python - azure-mgmt-keyvault - tests-weekly

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 27, 2021

No pipelines are associated with this pull request.

@mccoyp
Copy link
Member Author

mccoyp commented Oct 27, 2021

Ah, I see -- that pipeline isn't scheduled to run anymore either (forgot about that!). In that case, we can definitely remove this parameter since no azure-mgmt-keyvault pipelines are being run, @benbp

@mccoyp
Copy link
Member Author

mccoyp commented Oct 28, 2021

Closing in favor of #21458

@mccoyp mccoyp closed this Oct 28, 2021
@mccoyp mccoyp deleted the kv-tests-rg branch October 28, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@RAY-316 RAY-316 Awaiting requested review from RAY-316

Assignees

No one assigned

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mccoyp @benbp @AutorestCI