-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[textanalytics] add support for custom text actions #20721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kristapratico
merged 18 commits into
Azure:feature/ta-v3.2-preview.2
from
kristapratico:custom-text-actions
Oct 6, 2021
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f472f9a
impl for custom actions sync/async + models
kristapratico 0bd2899
remove project_name and deployment_name from result models
kristapratico 196d0de
update naming to classify documents
kristapratico 331233b
add samples for arch board
kristapratico 0faec44
fix sample
kristapratico 5462101
update naming to align with all langs
kristapratico bc032f4
update sample names
kristapratico 6cabea8
arch board feedback
kristapratico d83923c
rename samples and fix types
kristapratico 73872df
regenerate on latest swagger
kristapratico 384c4dd
add new tests and recordings
kristapratico 4f21b69
make corrections to code based on renames
kristapratico da68200
remove samples from PR
kristapratico 70dd0eb
fix
kristapratico 0f8c534
update changelog
kristapratico f3d7b4e
update missing docstrings
kristapratico 65ee5e6
bump azure-core for azure.core.rest
kristapratico 06134e2
merge feature branch
kristapratico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we usually include this in he changelog? don't think it's wrong to include, just didn't know we were supposed to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Before all the changelog header updates we had a section called "Dependency Updates" where this kind of info would normally go. There isn't really a place for it now which is why I put it under "Other Changes". Let me check the guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually can't find anything in the guidelines for this, but I don't think including it will hurt.