Skip to content

Run mypy in azure-keyvault-certificates CI #20525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YalinLi0312 merged 9 commits into from
Sep 8, 2021
Merged

Run mypy in azure-keyvault-certificates CI #20525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8a58a6
Fix mypy errors in keyvault certificates
Sep 1, 2021
9b0003f
Update mypy_hard_failure_package.py
Sep 2, 2021
f7a1716
Address comments
Sep 3, 2021
813d86a
Fix lint errors
Sep 3, 2021
a03a2be
WIP
Sep 3, 2021
3e5eb12
Address comments
Sep 4, 2021
c473033
Merge branch 'yall-mypy-certificates' of https://github.com/YalinLi03…
Sep 4, 2021
09b88b7
Fix a lint error
Sep 4, 2021
5770eba
Address comments
Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/tox/mypy_hard_failure_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"azure-eventhub",
"azure-identity",
"azure-keyvault-administration",
"azure-keyvault-certificates",
"azure-servicebus",
"azure-ai-textanalytics",
"azure-ai-formrecognizer",
Expand Down
12 changes: 7 additions & 5 deletions sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def begin_create_certificate(self, certificate_name, policy, **kwargs):
create_certificate_polling = CreateCertificatePoller(
get_certificate_command=get_certificate_command, interval=polling_interval
)
return LROPoller(command, create_certificate_operation, None, create_certificate_polling)
return LROPoller(command, create_certificate_operation, lambda *_: None, create_certificate_polling)

@distributed_trace
def get_certificate(self, certificate_name, **kwargs):
Expand Down Expand Up @@ -668,13 +668,15 @@ def set_contacts(self, contacts, **kwargs):
:caption: Create contacts
:dedent: 8
"""
contacts = self._client.set_certificate_contacts(
new_contacts = self._client.set_certificate_contacts(
vault_base_url=self.vault_url,
contacts=self._models.Contacts(contact_list=[c._to_certificate_contacts_item() for c in contacts]),
error_map=_error_map,
**kwargs
)
return [CertificateContact._from_certificate_contacts_item(contact_item=item) for item in contacts.contact_list]
return [
CertificateContact._from_certificate_contacts_item(contact_item=item) for item in new_contacts.contact_list
]

@distributed_trace
def get_contacts(self, **kwargs):
Expand Down Expand Up @@ -885,7 +887,7 @@ def create_issuer(self, issuer_name, provider, **kwargs):
phone=contact.phone,
)
for contact in admin_contacts
]
] # type: Optional[List[Any]]
else:
admin_details = None
if organization_id or admin_details:
Expand Down Expand Up @@ -946,7 +948,7 @@ def update_issuer(self, issuer_name, **kwargs):
phone=contact.phone,
)
for contact in admin_contacts
]
] # type: Optional[List[Any]]
else:
admin_details = None
if organization_id or admin_details:
Expand Down
Loading