Skip to content

[translation] fix poller.details #20392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristapratico merged 4 commits into from
Aug 24, 2021
Merged

[translation] fix poller.details #20392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08c9e9c
fixing docstring types for async client
kristapratico Aug 24, 2021
406bd36
populate poller.details.id immediately
kristapratico Aug 24, 2021
60fd969
pylint
kristapratico Aug 24, 2021
b06fd9c
add bug fix to changelog
kristapratico Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/translation/azure-ai-translation-document/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Breaking Changes

### Bugs Fixed
- The operation `id` under `details` of the poller object now populates correctly.

### Other Changes

Expand Down
8 changes: 5 additions & 3 deletions sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_polling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,11 @@ def details(self):

:rtype: ~azure.ai.translation.document.TranslationStatus
"""
return TranslationStatus._from_generated( # pylint: disable=protected-access
self._polling_method._current_body # pylint: disable=protected-access
)
if self._polling_method._current_body: # pylint: disable=protected-access
Copy link
Contributor

@iscai-msft iscai-msft Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: include as bug fix in changelog

return TranslationStatus._from_generated( # pylint: disable=protected-access
self._polling_method._current_body # pylint: disable=protected-access
)
return TranslationStatus(id=self._polling_method._get_id_from_headers()) # pylint: disable=protected-access

@classmethod
def from_continuation_token(cls, polling_method, continuation_token, **kwargs):
Expand Down
8 changes: 5 additions & 3 deletions ...slation/azure-ai-translation-document/azure/ai/translation/document/aio/_async_polling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ def details(self) -> TranslationStatus:

:rtype: ~azure.ai.translation.document.TranslationStatus
"""
return TranslationStatus._from_generated( # pylint: disable=protected-access
self._polling_method._current_body # pylint: disable=protected-access
)
if self._polling_method._current_body: # pylint: disable=protected-access
return TranslationStatus._from_generated( # pylint: disable=protected-access
self._polling_method._current_body # pylint: disable=protected-access
)
return TranslationStatus(id=self._polling_method._get_id_from_headers()) # pylint: disable=protected-access

@classmethod
def from_continuation_token(
Expand Down
4 changes: 2 additions & 2 deletions ...nslation/azure-ai-translation-document/azure/ai/translation/document/aio/_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def list_all_translation_statuses(self, **kwargs):
format: ["param1 asc/desc", "param2 asc/desc", ...]
(ex: 'created_on asc', 'created_on desc').
:return: A pageable of TranslationStatus.
:rtype: ~azure.core.paging.ItemPaged[TranslationStatus]
:rtype: ~azure.core.async_paging.AsyncItemPaged[TranslationStatus]
:raises ~azure.core.exceptions.HttpResponseError:

.. admonition:: Example:
Expand Down Expand Up @@ -336,7 +336,7 @@ def list_all_document_statuses(self, translation_id, **kwargs):
format: ["param1 asc/desc", "param2 asc/desc", ...]
(ex: 'created_on asc', 'created_on desc').
:return: A pageable of DocumentStatus.
:rtype: ~azure.core.paging.ItemPaged[DocumentStatus]
:rtype: ~azure.core.async_paging.AsyncItemPaged[DocumentStatus]
:raises ~azure.core.exceptions.HttpResponseError:

.. admonition:: Example:
Expand Down
1 change: 1 addition & 0 deletions sdk/translation/azure-ai-translation-document/tests/asynctestcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ async def _begin_and_validate_translation_async(self, async_client, translation_
# submit operation
poller = await async_client.begin_translation(translation_inputs)
self.assertIsNotNone(poller.id)
self.assertIsNotNone(poller.details.id)
# wait for result
doc_statuses = await poller.result()
# validate
Expand Down
1 change: 1 addition & 0 deletions sdk/translation/azure-ai-translation-document/tests/testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ def _begin_and_validate_translation(self, client, translation_inputs, total_docs
# submit job
poller = client.begin_translation(translation_inputs)
self.assertIsNotNone(poller.id)
self.assertIsNotNone(poller.details.id)
# wait for result
result = poller.result()
# validate
Expand Down